1484040 - Running testing under dom/tests/mochitest/dom-level2-core/ leak if shadow DOM is enabled in testing profile

Status: RESOLVED FIXED

(Core :: XML, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

It is enough to have just the following in mochitest.ini to see the leak.
If nsContentUtils::IsShadowDOMEnabled() check in XMLPrettyPrinter is disabled, there is no leak.


[DEFAULT]
support-files =
  DOMTestCase.js
  exclusions.js
  files/hc_staff.html
  files/hc_staff.svg
  files/hc_staff.xhtml
  files/hc_staff.xml
  files/internalSubset01.js
  files/nodtdstaff.svg
  files/nodtdstaff.xml
  files/staff.dtd
  files/staff.svg
  files/staff.xml
  files/staff2.dtd
  files/staff2.svg
  files/staff2.xml
  files/staffNS.dtd
  files/staffNS.svg
  files/staffNS.xml
  files/svgtest.js
  files/svgunit.js
  files/xhtml-lat1.ent
  files/xhtml-special.ent
  files/xhtml-symbol.ent
  files/xhtml1-frameset.dtd
  files/xhtml1-strict.dtd
  files/xhtml1-transitional.dtd

[test_setNamedItemNS02.html]
[test_setNamedItemNS03.html]

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

And when we leak, we leak the world.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: xml_pretty_printer_leak.diff

Better to actually unbind the child elements of shadow root properly.

See similar code at the end of Element::UnbindFromTree

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17adf3f924cc
unbind shadow DOM content when uninstalling shadow DOM based XML Pretty Printer, r=timdream

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/17adf3f924cc