1478559 - DevTools should handle Esc key with keydown event listener rather than keypress event listener

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Standard says that keypress should be fired only for printable characters, which excludes <kbd>Esc</kbd>.

We use keypress in some panels to handle esc, as well as in the toolbox to toggle the split console.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Using keyup sounds odd. keydown and keyup are event for physical state of key device, and keypress is event for text input by key (i.e., logical). keypress always follows keydown event if necessary. So, using keydown is same meaning in most cases.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #1)
> Using keyup sounds odd. keydown and keyup are event for physical state of
> key device, and keypress is event for text input by key (i.e., logical).
> keypress always follows keydown event if necessary. So, using keydown is
> same meaning in most cases.

thanks, I changed the bug title

Comment 3

[Erik Carrillo [:E_Carr]]

Nicolas,

Would you please assign this bug to me and also provide me with some pointers to get started. Thanks again.