Closed Bug 1475829 Opened 7 years ago Closed 7 years ago

Crash in static bool webrender::hit_test::HitTester::is_point_clipped_in_for_clip_chain

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: calixte, Assigned: mrobinson)

References

(Blocks 2 open bugs)

Details

(Keywords: crash, regression, Whiteboard: [gfx-noted])

Crash Data

This bug was filed from the Socorro interface and is report bp-43cfe22a-aa2f-4ff6-9736-1e6000180714. ============================================================= Top 7 frames of crashing thread: 0 xul.dll static void std::panicking::rust_panic_with_hook src/libstd/panicking.rs:521 1 xul.dll static void std::panicking::continue_panic_fmt src/libstd/panicking.rs:426 2 xul.dll static void std::panicking::rust_begin_panic src/libstd/panicking.rs:337 3 xul.dll static void core::panicking::panic_fmt src/libcore/panicking.rs:92 4 xul.dll static void core::panicking::panic_bounds_check src/libcore/panicking.rs:60 5 xul.dll static bool webrender::hit_test::HitTester::is_point_clipped_in_for_clip_chain gfx/webrender/src/hit_test.rs:203 6 xul.dll static void webrender::render_backend::RenderBackend::update_document gfx/webrender/src/render_backend.rs:1040 ============================================================= There are 62 crashes (from 37 installations) in nightly 63 starting with buildid 20180713220354. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1474300. [1] https://hg.mozilla.org/mozilla-central/rev?node=376e702ed3ea
Flags: needinfo?(bugmail)
Crash Signature: [@ static bool webrender::hit_test::HitTester::is_point_clipped_in_for_clip_chain] → [@ static bool webrender::hit_test::HitTester::is_point_clipped_in_for_clip_chain] [@ mozalloc_abort | abort | panic_abort::__rust_start_panic::abort | __rust_start_panic | rust_begin_unwind]
Blocks: wr-stability
Martin, can you look into this? It seems to be a regression from the last WR update and likely from your clip changes. It's seems to be a high volume crash, so I might back out the WR update.
Flags: needinfo?(bugmail) → needinfo?(mrobinson)
I'm looking at this now, as it does seem very likely related to splitting the ClipScrollTree. I'll see if I can reproduce this.
Flags: needinfo?(mrobinson)
I haven't been able to reproduce this, but I think this is caused by the same underlying issue as https://github.com/servo/webrender/issues/2898. In the meantime, I've created a work-around for what I believe is causing this specific problem at https://github.com/servo/webrender/pull/2899. I'll try to work on confirming this is the real issue. Sorry for the bustage!
Assignee: nobody → mrobinson
Blocks: stage-wr-nightly
Priority: -- → P1
Whiteboard: [gfx-noted]
I guess technically the crash "in the wild" was fixed by the backout of bug 1474300. But the latest WR update 1475252 seems to not be having this crash so it seems fixed upstream as well.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox63: affected → fixed
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.