1466794 - In 2-pane mode, highlighting a grid from the rules panel doesn't activate it in the layout panel

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: grid-highlighter-2-pane.mp4

STR:
1. open a website with a grid layout
2. open devtools, make sure it is in 2 pane mode at start
3. select the element with grid and click the icon in the Rules panel to highlight it
4. switch over to "Layout" tab

Expected result:
- the grid that was highlighted in the Rules panel will also be activated in the Layout panel

Actual result:
- the grid is not highlighted in the Layout panel

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1466794 - Make sure the highlighters overlay is initialized for the grid inspector.

Review commit: https://reviewboard.mozilla.org/r/249754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249754/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8983908 [details]
Bug 1466794 - Make sure the highlighters overlay is initialized for the grid inspector.

https://reviewboard.mozilla.org/r/249754/#review256104

Comment 3

[Patrick Brosset <:pbro>]

Maybe as a separate patch if you prefer, but it would be good to have a test for this. I believe we already have tests that check for the grid highlighter state, but we should add one for this specific use case of switching between modes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4da0d6998dd6
Make sure the highlighters overlay is initialized for the grid inspector. r=pbro

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4da0d6998dd6

Comment 6

[Cristian Fogel [:cfogel]]

Attachment: testCase.html

Attached test-case file, to make it easier to verify.

Comment 7

[Hani Yacoub, Desktop QA]

Verified on Firefox Nightly 66.0a1 (2018-12-18), Firefox 65.0b5 and Firefox 64 on Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.13.