Open Bug 1451361 Opened 7 years ago Updated 3 years ago

Grid highlighter can be off in some cases

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: julienw, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Attached file testcase-grid.html (obsolete) —
STR: 1. Open the attachment. 2. Open the devtools inspector. 3. Switch to the "layout" subpanel. 4. Enable the "grid" inspector => everything looks OK 5. resize the devtools => the highlighter is now off a few pixels 6. Disable, then enable again the "grid inspector" => everything looks OK again 7. hover the cells in the grid inspector below => the highlighter is off again
Attached image screenshot of the issue (obsolete) —
Attached image screenshot of the issue
Attachment #8964952 - Attachment is obsolete: true
So far I can't reproduce on macOS. Is this happening for you on Windows or Linux?
Flags: needinfo?(felash)
Component: Developer Tools: Layout Frame Inspector → Developer Tools: Inspector
Priority: -- → P3
Blocks: dt-grid
Summary: [Grid Inspector] The grid highlighter can be off in some cases → Grid highlighter can be off in some cases
Indeed I'm on Linux. This reminded me some bugs we could find with APZ in the past, so I tried disabling apz, but the bug still appears.
Flags: needinfo?(felash)
I just found something: step 5, if I resize towards increasing the browser window, the error doesn't appear. It appears only if I resize towards decreasing the browser window (means: increasing the devtools window). From my tests, it appears also whether the devtools are docked to the right or to the bottom. And I just realized something else: it looks like it depends on the fact the scrollbar is present. Which would explain why MacOS doesn't exhibit the behavior because the scrollbar is drawn "over" the page, which means it doesn't impact the layout... but it does impact the layout on other platforms. Now that I know this, I'll try to reproduce with a simpler case.
Attached file testcase-grid.html
Here is a simpler testcase. I found that we need the element to be in a flexible container with at least 2 children. I realized that here the scrollbars appear _because_ of the highlighter, likely because it's layed on top of the viewport and when we decrease the page width or height, the scrollbar then appears. Maybe it should go on top of the <html> element instead. But this is likely a different bug. I'll try to do a testcase that doesn't depend on this behavior.
Attachment #8964951 - Attachment is obsolete: true
I can't reproduce when I try to _produce_ the same behavior :(
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: