1448320 - onDetachedFront throws when receiving event

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Julian Descottes [:jdescottes]]

TypeError: this.onSelected is not a function: onDetachedFront@resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/rules/rules.js:1659

The callback throws because onSelected is never bound in the rule view.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1448320 - bind onDetachedFront in RuleView constructor;

Review commit: https://reviewboard.mozilla.org/r/230612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/230612/

Comment 2

[Julian Descottes [:jdescottes]]

Regression from 1382581

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8961758 [details]
Bug 1448320 - bind onDetachedFront in RuleView constructor;

https://reviewboard.mozilla.org/r/230612/#review236104

Comment 4

[Julian Descottes [:jdescottes]]

"The callback throws because onSelected is never bound in the rule view." 
Of course I meant "The callback throws because onDetachedFront is never bound in the rule view." :)

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e884e689aad
bind onDetachedFront in RuleView constructor;r=pbro

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4e884e689aad