1427392 - Scroll into view the grid container when clicking on the inspect icon

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In the list of grid containers, we have the inspect icon button next to each grid container Rep that shows the box model highlighter when mouseover and on click it selects the node in the markup view. 

This is to add a scrollIntoView of that node when the inspect icon button is also clicked.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1427392.patch

https://reviewboard.mozilla.org/r/209532/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87c5391593594eb26d51a00f68a85769a2e928f3

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1427392 - Scroll into view the grid container when clicking on the inspect icon.

Review commit: https://reviewboard.mozilla.org/r/209534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209534/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8939881 [details]
Bug 1427392 - Scroll into view the grid container when clicking on the inspect icon.

https://reviewboard.mozilla.org/r/209534/#review215878

::: devtools/client/inspector/grids/components/GridItem.js:120
(Diff revision 1)
> +    setSelectedNode(nodeFront, "layout-panel");
> +    nodeFront.scrollIntoView();

Both of these return promises that you should catch: `.catch(e => console.error(e))`.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d27d6f4af560
Scroll into view the grid container when clicking on the inspect icon. r=pbro

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d27d6f4af560