1422463 - Intermittent browser/base/content/test/performance/browser_windowopen_flicker.js | unexpected changed rect: ({x1:1042, x2:1049, y1:52, y2:55, w:7, h:3}), window width: 1280 -

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=149177273&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/S7rwT5xLSb6PwgWVqOITQQ/runs/0/artifacts/public/logs/live_backing.log

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Test got added in bug 1381405.

Comment 3

[Intermittent Failures Robot]

10 failures in 792 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 5
* autoland: 3
* mozilla-central: 2

Platform breakdown:
* linux32-stylo-disabled: 6
* linux64-stylo-disabled: 2
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1422463&startday=2017-11-27&endday=2017-12-03&tree=all

Comment 4

[Florian Quèze [:florian]]

Attachment: Fix

Most of the failures here are the rect of the urlbar down arrow having a smaller size than expected due to 2 frames having pixels of almost the same color at the end of the CSS opacity transition. This happened 8 times on the browser_windowopen_flicker.js test and once on the browser_startup_flicker.js test (bug 1422549).

One failure here is due to the 1x1px initial paint happening twice rather than once.

One failure is due to the location bar not being focused at first paint. This was already covered by the startup test, but never happened in my try runs for the windowopen case.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8934132 [details] [diff] [review]
Fix

Review of attachment 8934132 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me and thank you for nicely commenting and structuring the test after my original review. :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9f24c426257
Fix intermittent browser_windowopen_flicker.js and browser_startup_flicker.js failures by whitelisting more intermittent behaviors, r=johannh.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f9f24c426257

Comment 9

[Intermittent Failures Robot]

10 failures in 889 pushes (0.011 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 6
* try: 2
* mozilla-central: 2

Platform breakdown:
* linux64-stylo-disabled: 4
* linux64: 4
* linux32-stylo-disabled: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1422463&startday=2017-12-04&endday=2017-12-10&tree=all