1411878 - Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on shadow root of closed mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Ben Tian (inactive)]

Attribute getters to revise if shadow root mode is 'closed':

- Element.shadowRoot returns null
  https://dom.spec.whatwg.org/#dom-element-shadowroot

- Element.assignedSlot / TextNode.assignedSlot returns null
  https://dom.spec.whatwg.org/#dom-slotable-assignedslot

Comment 1

[Ben Tian (inactive)]

(In reply to Ben Tian [:btian] from comment #0)
> Attribute getters to revise if shadow root mode is 'closed':
> 
> - Element.shadowRoot returns null
>   https://dom.spec.whatwg.org/#dom-element-shadowroot
> 
> - Element.assignedSlot / TextNode.assignedSlot returns null
>   https://dom.spec.whatwg.org/#dom-slotable-assignedslot

Also Event.composedPath() for events associated with elements inside the shadow DOM, returns []
https://dom.spec.whatwg.org/#dom-event-composedpath

Comment 2

[Ben Tian (inactive)]

Attachment: WIP patch for Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot

WIP patch for following getters. The patch renames getters with [BinaryName] to avoid method name conflict with existing ones.

> - Element.shadowRoot returns null
>   https://dom.spec.whatwg.org/#dom-element-shadowroot
> 
> - Element.assignedSlot / TextNode.assignedSlot returns null
>   https://dom.spec.whatwg.org/#dom-slotable-assignedslot

Comment 3

[Ben Tian (inactive)]

Attachment: Bug 1411878 - Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on closed shadow root

Review commit: https://reviewboard.mozilla.org/r/194796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194796/

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8923673 [details]
Bug 1411878 - Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on closed shadow root

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194796/diff/1-2/

Comment 5

[Ben Tian (inactive)]

(In reply to Ben Tian [:btian] from comment #1)
> (In reply to Ben Tian [:btian] from comment #0)
> > Attribute getters to revise if shadow root mode is 'closed':
> > 
> > - Element.shadowRoot returns null
> >   https://dom.spec.whatwg.org/#dom-element-shadowroot
> > 
> > - Element.assignedSlot / TextNode.assignedSlot returns null
> >   https://dom.spec.whatwg.org/#dom-slotable-assignedslot

For this bug I'll land closed shadow root support for above getters first, and leave support for Event.composedPath either in bug 1412775 or a follow-up bug.

Rename bug title accordingly.

> Also Event.composedPath() for events associated with elements inside the
> shadow DOM, returns []
> https://dom.spec.whatwg.org/#dom-event-composedpath

Comment 6

[Ben Tian (inactive)]

Comment on attachment 8923673 [details]
Bug 1411878 - Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on closed shadow root

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194796/diff/2-3/

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8923673 [details]
Bug 1411878 - Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on closed shadow root

https://reviewboard.mozilla.org/r/194796/#review202628

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c13b0d4625b7
Support Element.shadowRoot and Element.assignedSlot / TextNode.assignedSlot on closed shadow root r=mrbkap

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c13b0d4625b7

Comment 10

[Chris Mills [:cmills]]

I've documented this by making sure the "Value" sections of the following pages include useful information about when the getters might return null:

https://developer.mozilla.org/en-US/docs/Web/API/Element/shadowRoot
https://developer.mozilla.org/en-US/docs/Web/API/Slotable/assignedSlot