1406860 - Intermittent browser/base/content/test/urlbar/browser_autocomplete_tag_star_visibility.js | Result should have expected type - Got (tag|favicon), expected bookmark

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=135657906&repo=autoland

https://queue.taskcluster.net/v1/task/dqvBR1hXSbOf2S103mrgNg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Marco Bonardo [:mak]]

Some of the tests in urlbar/ are intermittent-prone, they check richlistbox children existence, but they don't wait for the child to be up-to-date.

Among these:
browser_urlbar_search_no_speculative_connect_with_client_cert.js
browser_autocomplete_tag_star_visibility.js
browser_autocomplete_no_title.js

And most of the tests using gURLBar.popup.richlistbox.children:
http://searchfox.org/mozilla-central/search?q=gURLBar.popup.richlistbox.children&path=urlbar%2F

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This should be fixed by the follow-up in bug 1402555.

Comment 3

[Marco Bonardo [:mak]]

I'll still fix these tests, because sooner or later they'll bite us.

Comment 4

[Intermittent Failures Robot]

20 failures in 146 pushes (0.137 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 8
* mozilla-inbound: 7
* try: 3
* mozilla-central: 2

Platform breakdown:
* linux64-stylo-disabled: 10
* linux64: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1406860&startday=2017-10-09&endday=2017-10-09&tree=all

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1406860 - Make urlbar tests a bit more reliable.

Review commit: https://reviewboard.mozilla.org/r/188180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188180/

Comment 6

[Marco Bonardo [:mak]]

the only test failure I could still reproduce on Try is browser_urlbarSearchSuggestions_opt-out.js. That test is expected to click on the location bar and the notification should appear. Sometimes on Linux the click goes through, the locationbar is focused, but still the popup doesn't show. But that failure is already tracked in bug 1397154, so we can handle it apart, provided we understand what's up. Or we could disable it on Linux.

Comment 7

[Intermittent Failures Robot]

47 failures in 171 pushes (0.275 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 28
* autoland: 12
* try: 6
* mozilla-central: 1

Platform breakdown:
* linux64-stylo-disabled: 25
* linux64: 22

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1406860&startday=2017-10-10&endday=2017-10-10&tree=all

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8917159 [details]
Bug 1406860 - Make urlbar tests a bit more reliable.

https://reviewboard.mozilla.org/r/188180/#review193546

Looks good, lets try it :-)

::: browser/base/content/test/urlbar/browser_action_searchengine.js:13
(Diff revision 1)
>    let originalEngine = Services.search.currentEngine;
>    Services.search.currentEngine = engine;
>  
>    let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser, "about:mozilla");
>  
> -  registerCleanupFunction(() => {
> +  registerCleanupFunction(async function() {

Why not `async () => {`?

::: browser/base/content/test/urlbar/browser_action_searchengine_alias.js:14
(Diff revision 1)
>    let originalEngine = Services.search.currentEngine;
>    Services.search.currentEngine = engine;
>  
>    let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser, "about:mozilla");
>  
> -  registerCleanupFunction(() => {
> +  registerCleanupFunction(async function() {

ditto.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for picking this bug up so quickly and getting a fix in place

Comment 10

[Marco Bonardo [:mak]]

(In reply to Mark Banner (:standard8) from comment #8)
> Why not `async () => {`?

I probably didn't really mean to change that. In general I think arrow functions are a bit less optimized and more expensive because they have to bind "this". So, I usually tend to avoid them unless it's a very short callback (readability win) or I need the bind. In practice it doesn't really matter. I'll revert those changes for the sake of preserving blame.

Comment 11

[Marco Bonardo [:mak]]

oh wait, I wouldn't really preserve any blame here, cause the previous arrow function was not async. I'l leave the patch as-is, since arrow functions are not really needed here.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ac7fce0b369
Make urlbar tests a bit more reliable. r=standard8

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing xpcshell tests, e.g. toolkit/components/places/tests/unit/test_000_frecency.js:

https://hg.mozilla.org/integration/autoland/rev/f1fb2969c2b3f1f4a0f8a4be8dbe06fd0b6ec01f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1ac7fce0b369889c60010e66085d2bf0eb8bc250&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136229951&repo=autoland
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_000_frecency.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_463863.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_multi_queries.js | xpcshell return code: 0

Comment 14

[Marco Bonardo [:mak]]

my fault, I forgot that EMBED visits are not returned by history.fetch. It's a simple fix.

Comment 15

[Marco Bonardo [:mak]]

Comment on attachment 8917159 [details]
Bug 1406860 - Make urlbar tests a bit more reliable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188180/diff/1-2/

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2bb5a120db9
Make urlbar tests a bit more reliable. r=standard8

Comment 17

[Intermittent Failures Robot]

37 failures in 188 pushes (0.197 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 20
* mozilla-inbound: 10
* try: 4
* mozilla-central: 3

Platform breakdown:
* linux64-stylo-disabled: 24
* linux64: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1406860&startday=2017-10-11&endday=2017-10-11&tree=all

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c2bb5a120db9

Comment 19

[Intermittent Failures Robot]

140 failures in 947 pushes (0.148 failures/push) were associated with this bug in the last 7 days. 

This is the #7 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* mozilla-inbound: 66
* autoland: 49
* try: 13
* mozilla-central: 12

Platform breakdown:
* linux64-stylo-disabled: 79
* linux64: 61

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1406860&startday=2017-10-09&endday=2017-10-15&tree=all

Comment 20

[Intermittent Failures Robot]

1 failures in 864 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1406860&startday=2017-10-16&endday=2017-10-22&tree=all