1396700 - stylo: Minor clean up for ServoStyleSet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

A placeholder bug for some patches in my queue.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1396700 - Remove ServoStyleSet::UpdateStyleSheet().

This is no longer used.

Review commit: https://reviewboard.mozilla.org/r/176212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176212/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

The motivation of this patch is that clearing mPresContext should be an
implementation detail of XBL style set, so I create a method for that, and
remove ClearPresContext().

Review commit: https://reviewboard.mozilla.org/r/176214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176214/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8904402 [details]
Bug 1396700 - Remove ServoStyleSet::UpdateStyleSheet().

https://reviewboard.mozilla.org/r/176212/#review181150

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8904403 [details]
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

https://reviewboard.mozilla.org/r/176214/#review181152

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8904403 [details]
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176214/diff/1-2/

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de8f95049cfca56dff8823f02cffd8855f9643b3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1811ea2c78cc
Remove ServoStyleSet::UpdateStyleSheet(). r=xidorn
https://hg.mozilla.org/integration/autoland/rev/0a61f65ac5ed
Add a method to ServoStyleSet for creating XBL style set. r=xidorn

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8904402 [details]
Bug 1396700 - Remove ServoStyleSet::UpdateStyleSheet().

https://reviewboard.mozilla.org/r/176212/#review181180

(Already landed, but looks good)

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8904403 [details]
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

https://reviewboard.mozilla.org/r/176214/#review181184

::: layout/style/ServoStyleSet.cpp:131
(Diff revision 2)
> +  // which shouldn't be used for XBL styleset, so we clear it here to avoid
> +  // dangling pointer.
> +  set->mPresContext = nullptr;
> +
> +  return set;
> +}

Can we remove the ClearPresContext function now?

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8904403 [details]
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

https://reviewboard.mozilla.org/r/176214/#review181184

> Can we remove the ClearPresContext function now?

Yes. `ClearPresContext` has been removed in this patch.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8904403 [details]
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set.

https://reviewboard.mozilla.org/r/176214/#review181192

::: layout/style/ServoStyleSet.cpp:131
(Diff revision 2)
> +  // which shouldn't be used for XBL styleset, so we clear it here to avoid
> +  // dangling pointer.
> +  set->mPresContext = nullptr;
> +
> +  return set;
> +}

Whoops, missed that, thanks!

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1811ea2c78cc
https://hg.mozilla.org/mozilla-central/rev/0a61f65ac5ed