1388941 - stylo: min font size doesn't work within ruby

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Manish Goregaokar [:manishearth]]

./layout/reftests/css-ruby/min-font-size-1.html fails because of this.

Opening the testcase with font.minimum-size.ja = 16 will show that the main text is clamped to 16px, but the ruby atop it is extremely tiny.

<rt> uses -moz-min-font-size-ratio so we probably mess up there.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1388941 - Remove unnecessary fails(stylo) annotation from fuzzy test; heycam

Review commit: https://reviewboard.mozilla.org/r/166874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166874/

Comment 2

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1388941 - Correctly scale -moz-min-font-size-ratio ;

Review commit: https://reviewboard.mozilla.org/r/166876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166876/

Comment 3

[Manish Goregaokar [:manishearth]]

First commit is totally unrelated but it's a minor failure list fix so *shrug*

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8895632 [details]
Bug 1388941 - Correctly scale -moz-min-font-size-ratio ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166876/diff/1-2/

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8895632 [details]
Bug 1388941 - Correctly scale -moz-min-font-size-ratio ;

https://reviewboard.mozilla.org/r/166876/#review172054

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffa7014eb0c
Remove unnecessary fails(stylo) annotation from fuzzy test; r=heycam
https://hg.mozilla.org/integration/autoland/rev/7446c325724d
Correctly scale -moz-min-font-size-ratio ; r=heycam

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cffa7014eb0c
https://hg.mozilla.org/mozilla-central/rev/7446c325724d