Closed Bug 1380945 Opened 8 years ago Closed 8 years ago

stylo: cursor: progress is not honored.

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Testcase: <!doctype html> <style> html { cursor: progress; } </style> <script> alert(getComputedStyle(document.documentElement).cursor) </script> Expected: * progress Got: * default This makes stylo fail a test in acid3.
gecko.mako.rs states that Gecko doesn't support "progress" [1] so it converts it to "default", which is wrong. Gecko supports "progress", but it calls the value "NS_STYLE_CURSOR_SPINNING" [2], which is confusing. [1] https://github.com/servo/servo/blob/f49650ce96578c200c71b0a8fa50094764a3c76d/components/style/properties/gecko.mako.rs#L4522 [2] https://dxr.mozilla.org/mozilla-central/rev/8486950bd91878bf077a9ac33cb3c018288fe518/layout/style/nsCSSProps.cpp#1217
Yup, I noticed this and landed https://github.com/servo/servo/pull/17729. If there's no test passing for this I'll add one in this bug.
Priority: -- → P3
Assignee: nobody → canaltinova
Well, this looks fixed by Emilio already. Assigning to him. Emilio, do you remember any passing tests for that?
Assignee: canaltinova → emilio+bugs
I don't. Here's a testcase that my patch fixed: <div style="cursor: progress" id="target"></div> <script> assert_equals(getComputedStyle(target).cursor, "progress"); </script> So I guess I should land something like that.
Actually we already test this in "other values", I suspect the test was not enabled when this landed? Reverting the patch makes test_value_computation.html fail.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Yeah, test_value_computation.html was enabled in bug 1338764 a week ago, so it wasn't enabled when you fixed this bug.
You need to log in before you can comment on or make changes to this bug.