Closed Bug 1375336 Opened 8 years ago Closed 8 years ago

stylo: Component<Impl> size_of tests are failing for geckolib

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: bholley, Unassigned)

References

Details

I just noticed that ./mach cargo test -p selectors passes, but ./mach cargo-geckolib test -p selectors fails. Is that a regression? Are we running the latter on CI?
Flags: needinfo?(simon.sapin)
We are not running the latter on CI. The difference is due to field reordering starting in Rust 1.18 https://github.com/rust-lang/rust/pull/40377, as discussed in bug 1364148 comment 6. The difference disappears if I manually do the compiler’s work and move the case_sensitivity, operator, and never_matches fields before other fields in Component::AttributeInNoNamespace. Most of Gecko’s automation is on 1.18 since bug 1371406.
Flags: needinfo?(simon.sapin)
(In reply to Simon Sapin (:SimonSapin) from comment #1) > We are not running the latter on CI. The difference is due to field > reordering starting in Rust 1.18 > https://github.com/rust-lang/rust/pull/40377, as discussed in bug 1364148 > comment 6. The difference disappears if I manually do the compiler’s work > and move the case_sensitivity, operator, and never_matches fields before > other fields in Component::AttributeInNoNamespace. > > Most of Gecko’s automation is on 1.18 since bug 1371406. Doh! I'd totally forgotten about that. Sorry for the noise. :-(
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.