1372089 - stylo: WPT WebVTT tests failing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Shing Lyu [:shinglyu]]

TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/align_middle.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/align_middle_position_50.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/basic.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/bidi/bidi_ruby.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/bidi/u0041_first.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/bidi/u06E9_no_strong_dir.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/disable_controls_reposition.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/evil/size_90.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/evil/size_99.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/color_hex.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/color_hsla.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/color_rgba.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/cue_selector_single_colon.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/font_properties.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/font_shorthand.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/background_box.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/bold_object/bold_namespace.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/class_object/class_namespace.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/cue_func_selector_single_colon.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/italic_object/italic_namespace.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/not_allowed_properties.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/type_selector_root.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/underline_object/underline_namespace.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/voice_object/voice_namespace.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/outline_properties.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/outline_shorthand.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/text-decoration_line-through.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/text-decoration_overline.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/text-decoration_overline_underline_line-through.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/text-decoration_underline.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/text-shadow.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/white-space_normal_wrapped.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/white-space_nowrap_wrapped.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/cue/white-space_pre.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/default_styles/bold_object_default_font-style.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/default_styles/italic_object_default_font-style.html 
TEST-UNEXPECTED-FAIL | /webvtt/rendering/cues-with-video/processing-model/selectors/default_styles/underline_object_default_font-style.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/2_cues_overlapping_completely_move_up.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/2_cues_overlapping_partially_move_down.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/2_cues_overlapping_partially_move_up.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/evil/9_cues_overlapping_completely_all_cues_have_same_timestamp.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/evil/9_cues_overlapping_completely.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/line_50_percent.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/line_integer_and_percent_mixed_overlap.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/line_integer_and_percent_mixed_overlap_move_up.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/line_percent_and_integer_mixed_overlap.html 
TEST-UNEXPECTED-TIMEOUT | /webvtt/rendering/cues-with-video/processing-model/line_percent_and_integer_mixed_overlap_move_up.html

Comment 1

[Cameron McCormack (:heycam)]

stylo does support a ::cue pseudo-element.  Maybe it is confused because of the special way it's implemented in Gecko (in JS, and with a style="" attribute on it too).

Do you have a link to the reftest analyzer for these failures?

Comment 2

[Cameron McCormack (:heycam)]

Found it: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=105099965

Comment 3

[Cameron McCormack (:heycam)]

It looks like one of the <div>s that vtt.jsm creates (I think it's the one created at http://searchfox.org/mozilla-central/rev/61054508641ee76f9c49bcf7303ef3cfb6b410d2/dom/media/webvtt/vtt.jsm#929-934) gets the wrong styles.

Gecko:
  bottom: 0px
  height: 180px
  left: 0px
  perspective-origin: 160px 90px
  position: absolute
  right: 0px
  top: 0px
  transform-origin: 160px 90px

Stylo:
  bottom: auto
  height: 0px
  left: auto
  perspective-origin: 160px 0px
  position: static
  right: auto
  top: auto
  transform-origin: 160px 0px

Comment 4

[Cameron McCormack (:heycam)]

The problem is that we skip the style="" attribute on NAC, when we shouldn't.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=686080c9c7b79c7b44b5da73fdc1b7c1b18d443d

Comment 5

[Cameron McCormack (:heycam)]

Er, this one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f055d3ae588b8b1b8b0a79e0c216715541da80c2

Comment 6

[Cameron McCormack (:heycam)]

Attachment: patch

nsStyleSet::FileRules only skips the User and Doc (and ScopedDoc) cascade levels when resolving styles for NAC.  We should do the same here, instead of skipping the style rule and the animation rules.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8877077 [details] [diff] [review]
patch

Review of attachment 8877077 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks for fixing this! :)

Comment 8

[Cameron McCormack (:heycam)]

A try run with WPT enabled, to see if it actually fixes the tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1d0a6026cd6cc892fc0013b60c9d1f823e8eb6c

Comment 9

[Cameron McCormack (:heycam)]

(In reply to Cameron McCormack (:heycam) from comment #8)
> A try run with WPT enabled, to see if it actually fixes the tests:

Looks like it does.

Comment 10

[Cameron McCormack (:heycam)]

Merged: https://github.com/servo/servo/pull/17295