1370838 - Update dom/media/test/crashtests/789075-1.html crashtest

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

+++ This bug was initially created as a clone of Bug #1366502 +++

From https://bugzilla.mozilla.org/show_bug.cgi?id=1366502#c42


This test will play a big dimension video(9841x705) and check if gecko could handle that. But it also reset the video src to a empty string in onloadedmetadata(). Thus, we can't make sure the first frame of the video is always shown on the screen.

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1370838 - Because we need to ensure frame shown on the screen, so play the video to the end.

Review commit: https://reviewboard.mozilla.org/r/149276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149276/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8877848 [details]
Bug 1370838 - Because we need to ensure frame shown on the screen, so play the video to the end.

https://reviewboard.mozilla.org/r/149276/#review153742

Comment 3

[Benjamin Chen [:bechen]]

After discuss with Jerry, seems that we still need to modify the patch again.
Even though we dispatch the onloadeddata after the first frame(mContainer->SetCurrentFrame), we still can not guarantee the frame shown on the screen when receive onloadeddata event. The issue may not impact the real user, but impact our testing because we can not rely on the events to verify the screen frame.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Benjamin Chen [:bechen] from comment #3)
> Even though we dispatch the onloadeddata after the first
> frame(mContainer->SetCurrentFrame), we still can not guarantee the frame
> shown on the screen when receive onloadeddata event.

Is this because of vsync/compositor timing?

Comment 5

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06119c274030

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8877848 [details]
Bug 1370838 - Because we need to ensure frame shown on the screen, so play the video to the end.

https://reviewboard.mozilla.org/r/149276/#review154856

Clean the review request.
It's still not 100% showing the video on the screen with my laptop.

Comment 7

[Benjamin Chen [:bechen]]

Comment on attachment 8877848 [details]
Bug 1370838 - Because we need to ensure frame shown on the screen, so play the video to the end.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149276/diff/1-2/

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8877848 [details]
Bug 1370838 - Because we need to ensure frame shown on the screen, so play the video to the end.

https://reviewboard.mozilla.org/r/149276/#review154942

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e05bc6c0eb6
Because we need to ensure frame shown on the screen, so play the video to the end. r=jerry,jwwang

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7e05bc6c0eb6