1370274 - GridOutline component is sending too many requests to the server

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Matteo Ferretti [:zer0] [:matteo]]

I noticed during the development of bug 1359794, that the outline component seems invoking the `_update` method of grid highlighter more often than is expected.

Plus, after a while, especially when transformation are applied, it seems getting slower and slower. Not sure if it's directly related to the messages issue, if it's not we could file a different bug.

I think the problem is that there is no debounce when we leave the cell, but only when we enter in the cell. The mechanism should be the same for both actions, since both are calling an update on the highlighters.

http://searchfox.org/mozilla-central/source/devtools/client/inspector/grids/components/GridOutline.js#132-145

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1370274 - adding debouncing to both mouseenter and mouseleave;

Review commit: https://reviewboard.mozilla.org/r/147196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147196/

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

My apologies for the delay, I had this patch ready already this morning but I wanted to reduce the calls to the server even more, especially due the bad perf on OS X when the grid is transformed (See Bug 1371330).

I ended up to don't do anything more here because it was taking too much time.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8875787 [details]
Bug 1370274 - adding debouncing to both mouseenter and mouseleave;

https://reviewboard.mozilla.org/r/147196/#review151438

::: devtools/client/inspector/grids/components/GridOutline.js:132
(Diff revision 1)
>      }
>  
>      return height;
>    },
>  
> -  highlightCell(e) {
> +  onHighlightCell({target, type}) {

s/{target, type}/{ target, type }

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8875787 [details]
Bug 1370274 - adding debouncing to both mouseenter and mouseleave;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147196/diff/1-2/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Looks like this was landed in Bug 1368535.