1363131 - Showing the bookmarks panel is too slow the first time

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Florian Quèze [:florian]]

See this profile: https://perfht.ml/2qKzDn3

This is captured on the quantum reference hardware.

It's only slow the first time (it took ~300ms to appear), the second time is fine.

The panel I'm talking about is the panel when clicking the "Show your bookmarks" toolbar icon in the main toolbar.

Comment 1

[Marco Bonardo [:mak]]

The first time we unhide the panel and load the overlay. That's done to prevent slowing down startup.

Comment 2

[Florian Quèze [:florian]]

In this profile we start with 52ms doing main thread IO to get an image from a jar archive: https://perf-html.io/public/f154d24c598d4cd31a98f5f02d43b06e2d123907/calltree/?range=422.0384_444.8391~436.9647_437.3012&search=GetData&thread=0
Any idea which image this is? It seems strange to me that we need to open a new jar file to display this menu. Maybe the pocket icon?

Then we do a bunch of places related stuff. Some initialization indeed. Including loading the nsLivemarkService.js file. PageIconProtocolhandler.js' newChannel2 implementation is also visible.

We have a layout flush in get_alignmentPosition (popup.xml) : https://perf-html.io/public/f154d24c598d4cd31a98f5f02d43b06e2d123907/calltree/?callTreeFilters=prefixjs-JMoJMpyxs&range=422.0384_444.8391~436.9647_437.3012&search=popup&thread=0 (bug 1356674)

At the end of the profile we have nsSoundPlayer::SoundReleaser::Run adding to the existing jank. I filed bug 1363163 on this.

Comment 4

[Marco Bonardo [:mak]]

After so many years, too many things have changed, so this would require a new profile measurement.
The bookmarks menu button is not in the toolbar by default today. We don't know if the problem is affecting many users.

Comment 5

[Dale Harvey (:daleharvey)]

Gijs has mentioned that a large amount of time is being spent on SVG parsing @ https://bugzilla.mozilla.org/show_bug.cgi?id=1383758#c7

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Performance Impact	medium	bug 1383758

For more information, please visit auto_nag documentation.