1362954 - --disable-accessibility fails to build

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Mats Palmgren (inactive)]

STR
1. Add "ac_add_options --disable-accessibility" to your .mozconfig
2. build

ACTUAL RESULTS

 3:11.40 In file included from /md1/objdir/md1/src/mc/parser/html/Unified_cpp_parser_html0.cpp:20:
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:842:38: error: no member named 'aria_valuemax' in 'nsGkAtoms'
 3:11.40     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuemax), ALL_NO_PREFIX);
 3:11.40                           ~~~~~~~~~~~^
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:844:38: error: no member named 'aria_labelledby' in 'nsGkAtoms'
 3:11.40     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_labelledby), ALL_NO_PREFIX);
 3:11.40                           ~~~~~~~~~~~^
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:846:38: error: no member named 'aria_describedby' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_describedby), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:848:38: error: no member named 'aria_disabled' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_disabled), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:850:38: error: no member named 'aria_checked' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_checked), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
...

Comment 1

[Mats Palmgren (inactive)]

A regression from bug 1269490 perhaps?

Comment 2

[Henri Sivonen (:hsivonen)]

Yes. Fewer atoms should be behind #ifdef ACCESSIBILITY in the atom list.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: move some accessibility atoms out of the ACCESSIBILITY ifdef

Fixes the build locally for me. Green on Try too.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f23fee7b9d52c11404b0801498507855243a510

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c66e8805fcb
Move some atoms outside of the ACCESSIBILITY guard to fix --disable-accessibility bustage. r=hsivonen

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c66e8805fcb