Closed
Bug 1356284
Opened 8 years ago
Closed 8 years ago
Avoid concat in Sqlite.jsm::bindParam
Categories
(Core :: SQLite and Embedded Database Bindings, defect, P1)
Core
SQLite and Embedded Database Bindings
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [fxsearch][photon-performance])
Attachments
(1 file)
The concat call in bindParam appears in some profiles, it is not strictly needed in the most common cases, so let's avoid it.
|
||
Updated•8 years ago
|
Flags: qe-verify?
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858014 [details]
Bug 1356284 - Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam.
https://reviewboard.mozilla.org/r/130048/#review132678
Attachment #8858014 -
Flags: review?(florian) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/e8e2593692a5
Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam. r=florian
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•8 years ago
|
Iteration: --- → 55.3 - Apr 17
|
|
||
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•