Closed
Bug 1354738
Opened 8 years ago
Closed 8 years ago
Initializing sync when opening the tab context menu the first time causes jank
Categories
(Firefox :: Sync, defect, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: florian, Assigned: eoger)
Details
Attachments
(1 file)
See this profile: https://perfht.ml/2nnRBLr
This session of Firefox had been running for several hours. This profile doesn't have sync configured.
The first time I opened the context menu on a tab (to use the "Close Other Tabs" item), updateTabContextMenu from browser-fxaccounts.js blocked the UI thread for 132ms at http://searchfox.org/mozilla-central/rev/fcd9f1480d65f1a5df2acda97eb07a7e133f6ed4/browser/base/content/browser-fxaccounts.js#384
|
Assignee | |
Comment 1•8 years ago
|
||
I guess we could do the same thing we do here [0], http://searchfox.org/mozilla-central/rev/fcd9f1480d65f1a5df2acda97eb07a7e133f6ed4/browser/base/content/browser-fxaccounts.js#66-73 but that would mean you can't send a tab in the first 8 second you opened Firefox.
|
||
Updated•8 years ago
|
Assignee: nobody → eoger
Priority: -- → P2
|
||
Updated•8 years ago
|
No longer blocks: photon-performance-triage
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858920 [details]
Bug 1354738 - Don't force Sync initialization on context menu open.
https://reviewboard.mozilla.org/r/130912/#review133610
Attachment #8858920 -
Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9788db4055d
Don't force Sync initialization on context menu open. r=markh
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•