1353147 - Allow Gtk+ theme override

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug 1158076 comment 115

It will be useful to allow override Gtk+ theme for web content when default desktop theme is dark and there isn't any light alternative available.

For instance Cinnamon has a default theme Arc (see https://bugzilla.redhat.com/show_bug.cgi?id=1421143)

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1353147 - Allow Gtk+ theme override,

Allow to override Gtk+ theme for content process when e10s is enabled.

Review commit: https://reviewboard.mozilla.org/r/126310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126310/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I'm going to ask Gnome guys if that's the correct way how to override Gtk+ theme from application.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8854381 [details]
Bug 1353147 - Allow Gtk+ theme override,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126310/diff/1-2/

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8854381 [details]
Bug 1353147 - Allow Gtk+ theme override,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126310/diff/2-3/

Comment 5

[Martin Stránský [:stransky] (ni? me)]

You're right, gtk-theme-name is the right way. I had a wrong string conversion in my original patch which caused the malfunction.

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8854381 [details]
Bug 1353147 - Allow Gtk+ theme override,

https://reviewboard.mozilla.org/r/126310/#review129824

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf2c044e135
Allow Gtk+ theme override, r=karlt

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/daf2c044e135