1349885 - stylo: Simplify computation of float and position.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

There's no reason they need to be early properties, and Manish was working around that float does indeed depend on writing mode in bug 1341775.

Here's a patch that fixes it properly.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1349885: stylo: Simplify computation of float and position.

Review commit: https://reviewboard.mozilla.org/r/123046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123046/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8adf3d0d06570f5a76c2cc1f853b368d5a8c8350

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8850453 [details]
Bug 1349885: stylo: Simplify computation of float and position.

https://reviewboard.mozilla.org/r/123046/#review125334

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8850453 [details]
Bug 1349885: stylo: Simplify computation of float and position.

https://reviewboard.mozilla.org/r/123046/#review125340

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249627eaa999
Reftest expectations update. r=emilio

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/249627eaa999