Open Bug 1346065 Opened 9 years ago Updated 3 years ago

stylo: Expose STYLO_THREADS environment value and add an assertion in nsRefreshDriver::EnsureTimerStarted()

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

Tracking Status
firefox57 --- wontfix

People

(Reporter: hiro, Unassigned)

References

Details

See bug 1341985 comment 41. We well add an assertion in nsRefreshDriver::EnsureTimerStarted() in bug 1341985 that checks that we are not in the servo traversal or we are on the main-thread. But if the STYLO_THREADS value is 1, the assertion is not useful, we do avoid the situation somehow. But at this moment I don't want to use PR_GetEnv(XX) in nsRefreshDriver. Instead I'd prefer to add a function named StyloThreadsNum() or something somewhere.
I don't think we should use the STYLO_THREADS environment variable directly, since it is only one way of determining how many style worker threads get created. (If the variable is not set, we do num_cpus * 0.75 or something.) Also there are plans to heuristically decide when to perform restyling sequentially (bug 1345691). To do this I guess we need to expose something from the rust side. But I don't think this is high priority.
Priority: P3 → --
P4 based on Cameron's assessment in comment 1.
Priority: -- → P4
status-firefox57=wontfix unless someone thinks this bug should block 57
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.