1339121 - layout panel : do not mention multiple overlays in grid overlay picker

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

The layout panel allows to select which overlay to display.
Ultimately this will allow to select several overlays hence the title "Overlay Multiple Grids" and the use of checkbox.

In the mvp however, only one overlay can be picked. Title should be changed to "Overlay Grid" or "Select Overlay Grid".

Also the checkboxes could be switched to radio buttons in the meantime.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1339121 - update header of grid overlay section;

Review commit: https://reviewboard.mozilla.org/r/112716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112716/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8837602 [details]
Bug 1339121 - update header of grid overlay section;

https://reviewboard.mozilla.org/r/112716/#review114216

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b0fffa1283
update header of grid overlay section;r=gl

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16b0fffa1283

Comment 5

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

(In reply to Julian Descottes [:jdescottes] from comment #0)
> The layout panel allows to select which overlay to display.
> Ultimately this will allow to select several overlays hence the title
> "Overlay Multiple Grids" and the use of checkbox.

Does it mean that layout.overlayMultipleGrids is not used, and might not be in the future?

Comment 6

[Julian Descottes [:jdescottes]]

Right now layout.overlayMultipleGrids is not used. But it will be used as soon as we support displaying several grids at the same time.

When this happens, the new string introduced here (layout.overlayGrid) will no longer be used and will be removed.
We thought it made more sense to keep the existing layout.overlayMultipleGrids in the properties file, since it will be used in the future.

Comment 7

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

(In reply to Julian Descottes [:jdescottes] from comment #6)
> When this happens, the new string introduced here (layout.overlayGrid) will
> no longer be used and will be removed.
> We thought it made more sense to keep the existing
> layout.overlayMultipleGrids in the properties file, since it will be used in
> the future.

It makes absolutely sense. Thanks for confirming.