1327131 - Changing zoom level causes visual twitching of zoom indicator and dropmarker

Status: RESOLVED DUPLICATE of bug 712602

(Firefox :: Address Bar, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161001030430 (2016-10-01)
STR_1:
1. Open homepage, set zoom level to "110%"
2. Navigate to http://example.org/ in that tab
3. Focus urlbar, press Ctrl+"-" to set zoom level to 90%
4. Press Alt+Left to navigate to homepage

AR:
 Step 2 - zoom indicator appears in urlbar, causing twitching of dropmarker
 Step 3 - Zoom indicator in urlbar twitches, causing twitching of dropmarker
ER:  X or at least Y
 X) Step 3 - zoom indicator shouldn't cause twitching of dropmarker
 Y) Step 4 - zoom indicator shouldn't twitch (just like zoom level toolbarbutton)

This was broken 2 times - first in bug 1203494 [1], then in bug 565718 [2]. Regression ranges:
> [1] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c69e31de9aec2b9e8c0b3128ac6dc3897aa7381f&tochange=3e8dde8f8c174cce2c0b65c951808f88e35d1875
> [2] https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=8725f14625e0c87776f9acf66e6712ceca301000&tochange=ef0801fdc7abe018a8b026c00e8bdebcc690001c

Comment 1

[arni2033]

Reference of good behavior:
Zoom level toolbarbutton doesn't change width when it changes from 90% to 110%

Comment 2

[:Gijs (he/him)]

We can set the width the indicator which will stop it changing size depending on zoom level. I don't think there's anything we intend to do about the 'twitching' of the dropmarker otherwise. Stephen, how are we doing with plans to get rid of that dropmarker altogether?

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I managed to reproduce the issue on Windows 10 x64, Windows 7 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6, using 51.0b14 (20170112171116). Marking this as new.

Comment 4

[Marco Bonardo [:mak]]

Another problem reported on reddit, is that when the zoom indicator appears, the history dropdown is pushed away, and that doesn't work well with muscle memory.
We could avoid the magic movement of ui elements by moving the historydropmarker element after the urlbar-icons, but then we'd have an empty space to their right, filled only on hover, since the dropmarker is only shown on hover.
On the other side, it's also from some time that we are evaluating completely removing the dropmarker ( I think we had some clicks heatmaps around)...

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to :Gijs from comment #2)
> We can set the width the indicator which will stop it changing size
> depending on zoom level. I don't think there's anything we intend to do
> about the 'twitching' of the dropmarker otherwise. Stephen, how are we doing
> with plans to get rid of that dropmarker altogether?

There is a bug to remove that dropdown. I haven't looked into it recently though. I think making the zoom indicator a fixed width is the right thing to regardless of that though.