Closed Bug 1321150 Opened 9 years ago Closed 7 years ago

stylo: various style system classes that have Gecko and Servo versions are inconsistently named

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox57 --- wontfix

People

(Reporter: heycam, Unassigned)

References

Details

Currently we have: Base class Gecko class Servo class ---------- ----------- ----------- StyleSet nsStyleSet ServoStyleSet StyleSheet CSSStyleSheet ServoStyleSheet RestyleManagerBase RestyleManager ServoRestyleManager DeclarationBlock Declaration ServoDeclarationBlock CSSRuleList CSSRuleListImpl ServoCSSRuleList - StyleRule ServoStyleRule and maybe some others I missed. We should probably have a consistent naming scheme, to help others reading the code, such as: Base class Gecko class Servo class ---------- ----------- ----------- StyleSet GeckoStyleSet ServoStyleSet StyleSheet GeckoStyleSheet ServoStyleSheet RestyleManager GeckoRestyleManager ServoRestyleManager DeclarationBlock GeckoDeclarationBlock ServoDeclarationBlock CSSRuleList GeckoCSSRuleList ServoCSSRuleList - GeckoStyleRule ServoStyleRule
(In reply to Cameron McCormack (:heycam) from comment #0) > CSSRuleList GeckoCSSRuleList ServoCSSRuleList We have two different CSSRuleList implementation for Gecko: one is for StyleSheet (which is CSSRuleListImpl listed here), another is for grouping rules (which is GroupRuleRuleList in nsCSSRules.cpp). Stylo may have two in the future as well, one for StyleSheet and some grouping rules (@media, @support, etc.), and another for @keyframes rule (because it uses different data struct in Servo). As mentioned above, the two subclasses used for Gecko doesn't 1:1 match those for Servo, so the naming here could be tricky.
I'm renaming the RestyleManager classes as part of bug 1297899.
P4 because this would make code maintenance easier, but it's not a blocker.
Depends on: 1297899
Priority: -- → P4
Summary: various style system classes that have Gecko and Servo versions are inconsistently named → stylo: various style system classes that have Gecko and Servo versions are inconsistently named
status-firefox57=wontfix unless someone thinks this bug should block 57
status-firefox57: --- → wontfix
The Gecko classes are gone now. Any renaming of the Servo classes that are left can be done in other bugs.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.