1320276 - [webvtt] Fix web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

Modify the test "web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html" in order to follow the spec.

(1) The default value of line should be "auto:
(2) The value of cue.line would return the line's value, instead of computedLine's. 

[1] https://w3c.github.io/webvtt/#webvtt-cue-line
[2] https://w3c.github.io/webvtt/#dom-vttcue-line

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1320276 - Fix web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html.

Modify the test "web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html" in order to follow the spec.

(1) The default value of line should be "auto" [1]
- change all "-1" into "auto"

(2) The cue.line should return the line's value, instead of computedLine's [2]
- change "-2" into "auto" (-2 is the value of the computedLine)

[1] https://w3c.github.io/webvtt/#webvtt-cue-line
[2] https://w3c.github.io/webvtt/#dom-vttcue-line

Review commit: https://reviewboard.mozilla.org/r/95606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95606/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8814333 [details]
Bug 1320276 - Fix web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html.

https://reviewboard.mozilla.org/r/95606/#review95696

Hooray!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd10f23e5aa3
Fix web-platform-tests/webvtt/webvtt-api-for-browsers/vttcue-interface/line.html. r=rillian

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fd10f23e5aa3