1317309 - Throw a TypeError when passing a symbol value to RegExp and RegExp.prototype.compile

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

Test case:
---
RegExp(Symbol())
---

Expected: Throws a TypeError
Actual: No exception thrown

Comment 1

[André Bargull [:anba]]

Attachment: bug1317309.patch

It looks like ToAtom was overlooked when Symbols were added to the runtime.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8810531 [details] [diff] [review]
bug1317309.patch

Review of attachment 8810531 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.

::: js/src/jsatom.cpp
@@ +515,5 @@
> +                                      JSMSG_SYMBOL_TO_STRING);
> +        }
> +        return nullptr;
> +    }
> +    MOZ_ASSERT(v.isUndefined());

It'd sure be nice to be able to enforce exhaustive matching for Value types.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4419ad4be612
Throw a TypeError when passing a Symbol value to ToAtom. r=till

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4419ad4be612

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Will ride the train from 53