1302240 - Report content backend to telemetry

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Report content backend to telemetry

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbf05de1506e

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8790458 [details] [diff] [review]
Report content backend to telemetry

Review of attachment 8790458 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine but since GetContentBackend doesn't depend on Windows, can we move it to GfxInfoBase?

Note: you'll probably fail a unit test somewhere in toolkit since we test the fields of the environment string. But it's easy to fix when you get it.

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to David Anderson [:dvander] from comment #2)
> Comment on attachment 8790458 [details] [diff] [review]
> Report content backend to telemetry
> 
> Review of attachment 8790458 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine but since GetContentBackend doesn't depend on Windows, can we
> move it to GfxInfoBase?

Fixed.

> 
> Note: you'll probably fail a unit test somewhere in toolkit since we test
> the fields of the environment string. But it's easy to fix when you get it.

Try looks ok, I didn't see a test fail - https://treeherder.mozilla.org/#/jobs?repo=try&revision=5de7915fdf3d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/682489fca27b
Report content backend to telemetry. r=dvander

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/682489fca27b

Comment 6

[Alison Shiue]

This patch did a performance improvement in talos, thanks.

Improvements:

 11%  sessionrestore_no_auto_restore linux64 opt       1254.92 -> 1113.08
 11%  sessionrestore linux64 opt                       1198.33 -> 1063.17
  3%  sessionrestore osx-10-10 opt                     1060.17 -> 1023.5
  3%  sessionrestore_no_auto_restore osx-10-10 opt     1100.62 -> 1066

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=3108

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

There's no way this patch had performance impact. It's diagnostic.

Comment 8

[Mason Chang [Inactive] [:mchang]]

(In reply to David Anderson [:dvander] from comment #7)
> There's no way this patch had performance impact. It's diagnostic.

I concur, this talos improvement makes no sense..

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

I am also confused by this, but it does show up with a few retriggers as the root cause very clearly.