Closed
Bug 1289620
Opened 9 years ago
Closed 9 years ago
Upstream most of the hacks in the stylo branch
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(4 files)
1.07 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
8.10 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
10.47 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
5.65 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
A lot of the stuff in the stylo branch can just move into the tree, which will make things more manageable.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8774971 -
Flags: review+
Assignee | ||
Comment 2•9 years ago
|
||
Aside from the parser-side hacks, this should subsumes all the current scattered
logic in the stylo tree to handle initial styling.
Attachment #8774973 -
Flags: review?(cam)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8774974 -
Flags: review?(cam)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8774975 -
Flags: review?(cam)
Assignee | ||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8774973 [details] [diff] [review]
Part 2 - Hook up initial styling. v1
Review of attachment 8774973 [details] [diff] [review]:
-----------------------------------------------------------------
s/subsumes/subsume/ in the commit message.
Attachment #8774973 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8774974 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8774975 -
Flags: review?(cam) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d9e30d1dac1
Stub out ReparentStyleContext. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/489e458bd972
Hook up initial styling. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9751329a6d
Separate presshell attachment and detachment in nsPresContext. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/43638c0b16bc
Initialize the correct restyle manager when we attach the PresShell. r=heycam
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d9e30d1dac1
https://hg.mozilla.org/mozilla-central/rev/489e458bd972
https://hg.mozilla.org/mozilla-central/rev/5a9751329a6d
https://hg.mozilla.org/mozilla-central/rev/43638c0b16bc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•