1287073 - remove SEC_FORCE_INHERIT_PRINCIPAL_WAS_DROPPED from nsILoadInfo

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1162772#c91

Comment 1

[Jonathan Watt [:jwatt]]

Thanks for taking this, Yoshi.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8772253 [details] [diff] [review]
Patch.

Review of attachment 8772253 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/LoadInfo.cpp
@@ +203,5 @@
>    , mTainting(LoadTainting::Basic)
>    , mUpgradeInsecureRequests(false)
>    , mVerifySignedContent(false)
>    , mEnforceSRI(false)
> +  , mForceInheritPrincipalDropped(false)

You should initialize this member in the copy ctor as well.

You also need to handle the member in LoadInfoToLoadInfoArgs and LoadInfoArgsToLoadInfo

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8774282 [details] [diff] [review]
Patch. v2

Hi Jonas
Thanks for the previous review, I've updated copy cstor and LoadInfoArgs as well.

Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af00de9bc663
remove SEC_FORCE_INHERIT_PRINCIPAL_WAS_DROPPED from nsILoadInfo r=sicking

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af00de9bc663