1282643 - [css-grid] Reject repeat() column tracks in <grid-template> when there's a grid template area string in the row part

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mats Palmgren (inactive)]

It appears the 'grid-template' syntax no longer allows repeat() column tracks
if there a is a grid template area string in the row part:
https://drafts.csswg.org/css-grid/#grid-template-ascii

[ <line-names>? <string> <track-size>? <line-names>? ]+ [ / <explicit-track-list> ]?

<explicit-track-list> = [ <line-names>? <track-size> ]+ <line-names>?

https://hg.csswg.org/drafts/rev/de8ef74e4048

Comment 1

[Mats Palmgren (inactive)]

Here's some more background:

  - Tentatively the group resolved that auto-repeat should be
      invalid despite existing implementations. And remove the
      grammar that allows repeat() for columns as it was an accident.
      - If there are no objections on the mailing list before the
          next telecon, the group will formally resolve.

https://lists.w3.org/Archives/Public/www-style/2016May/0231.html

The problem was originally reported by Rego:
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix+tests

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f30d53c0d70

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8766555 [details] [diff] [review]
fix+tests

Review of attachment 8766555 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- r=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a72342d3ad90
[css-grid] Reject repeat() column tracks in <grid-template> when there's a grid template area string in the row part.  r=dholbert

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a72342d3ad90