1277934 - [css-grid] write more reftests for align/justify-self/content:[last-]baseline

Status: NEW

(Core :: Layout: Grid, enhancement, P4)

Description

[Mats Palmgren (inactive)]

We need more reftests that checks all possible value combinations
of these properties.  Only some combinations should result in
baseline alignment, see the text on Grid Items here:
https://drafts.csswg.org/css-align-3/#baseline-align-content

Comment 1

[Joseph]

How would I start with this? https://developer.mozilla.org/en-US/docs/Mozilla/Creating_reftest-based_unit_tests this?

Comment 2

[Mats Palmgren (inactive)]

Yes, that document looks good to me.  You can find our existing CSS Grid reftests
under layout/reftests/css-grid/ , so that's where the new tests should go.

If you want to run just the new reftests that you create (to save time) you can
create a file in that folder that just lists your tests (see reftest.list for syntax)
and run it with:
./mach reftest layout/reftests/css-grid/mytests.list

Comment 3

[Mats Palmgren (inactive)]

You might need to add the following line in a .mozconfig file in the top
source dir before starting the build:
ac_add_options --enable-debug

Comment 4

[subhamy142]

Hey evreybody! Since this bug is updated 6 months back , i wanted to make sure if its still available . I'm newbie at this ,right now i'm reading this
https://developer.mozilla.org/en-US/docs/Mozilla/Creating_reftest-based_unit_tests Will start writing the patch as soon as I... well....try

plzz guide me if u can :)

Comment 5

[subhamy142]

Attachment: Bug 1277934 -Gave a new reftest for justify-self:baseline. r=dholbert,emilio

Comment 6

[Mats Palmgren (inactive)]

Attachment: Example baseline test

In this test I also added a bit of padding on one of the baseline aligned items so that the intrinsic size of the container depends on the result of the baseline alignment. It would be nice if we could include that too so that we exercise that part of the layout code as well.

Comment 7

[Mats Palmgren (inactive)]

Don't forget to also test baseline values for align-content/justify-content, combined with themselves and with *-self baseline values. If you take all the properties/values that can affect baseline alignment then there are literally thousands of combinations. Please tests as many as possible. (Note that each test file needs to render in 600px x 600px so they won't fit in just one file.)

Comment 8

[Mats Palmgren (inactive)]

It's worth testing align/justify-self/content:[last-]baseline on grid containers too of course, but perhaps that should be a follow-up bug. Also, we have some tests for that already: see layout/reftests/css-grid/grid-container-baselines-*

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[Saman]

I am an outreachy applicant and I want to contribute to this task kindly assign it to me. Thank you

Comment 11

[manisha270417]

Is this Issue still active?

Comment 12

[Ranjan]

Is this issue still active? I would love to contribute to it as my first bug. Kindly assign it to me!

Comment 13

[Favour]

I would love to contribute to it as my first bug. Kindly assign it to me boss

Comment 14

[Jennifer]

Hi, I am an outreachy applicant. I am interested in working on this. Can I be assigned this?

Comment 15

[Patryk Gruszka]

Attachment: Bug 1277934 - [css-grid] write more reftests for align/justify-self/content:[last-]baseline. r=emilio

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f19e5c90d1c
[css-grid] write more reftests for align/justify-self/content:[last-]baseline. r=emilio

Comment 17

[Atila Butkovits]

Backed out for causing failures at grid-container-baselines-007.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3e9553e763c05a226a06eb22a8f60efef211bafd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4f19e5c90d1c8a70ae19d7f85fdc9aa23c1f6abe

Failure log: https://treeherder.mozilla.org/logviewer?job_id=456053094&repo=autoland&lineNumber=9431

Comment 18

[Patryk Gruszka]

Attachment: Bug 1277934 - [css-grid] fixed reftests for align/justify-self/content:[last-]baseline. r=emilio

Comment 19

[Patryk Gruszka]

I've updated the failed test and hope it's good this time. Can someone please run the job to test it across all environments?

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 21

[Ian Kilpatrick [:iank]]

From: https://issues.chromium.org/issues/364820101

justify-self baseline has an affect, by synthesizing the baseline using a horizontal-tb writing-mode.

Potentially: https://bugzilla.mozilla.org/show_bug.cgi?id=1913789 may fix this issue.
Likely grid-container-baselines-006 is incorrect in the above patches.

Ian