1266131 - [css-grid] 'order' shouldn't affect grid-aligned abs.pos. descendants

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Mats Palmgren (inactive)]

dbaron says the CSSWG has decided to change the Grid spec.

Comment 1

[Mats Palmgren (inactive)]

https://lists.w3.org/Archives/Public/www-style/2016Apr/0351.html

  -   RESOLVED: Remove order-based reordering of abspos flex
                children. For painting purposes they're treated as
                having an order of 0.

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

Comment 3

[Mats Palmgren (inactive)]

Attachment: remove now dead code

Comment 4

[Mats Palmgren (inactive)]

Attachment: adjust reftest

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8744759 [details] [diff] [review]
fix

Review of attachment 8744759 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGridContainerFrame.cpp
@@ +5213,5 @@
>    // Our children are all grid-level boxes, which behave the same as
>    // inline-blocks in painting, so their borders/backgrounds all go on
>    // the BlockBorderBackgrounds list.
>    // Also, we capture positioned descendants so we can sort them by
>    // CSS 'order'.

The last two lines of this comment need to be removed now (about "positioned descendants" and "order"), since the described code is now removed.

(This is immediately before your changes to this file.)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a33d68388287
https://hg.mozilla.org/integration/mozilla-inbound/rev/4614975cc508
https://hg.mozilla.org/integration/mozilla-inbound/rev/de2849584be2

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a33d68388287
https://hg.mozilla.org/mozilla-central/rev/4614975cc508
https://hg.mozilla.org/mozilla-central/rev/de2849584be2

Comment 8

[yisibl]

Are you going to support text-emphasis* and opacity properties?

(In reply to Mats Palmgren (:mats) from comment #3)
> Created attachment 8744760 [details] [diff] [review]
> remove now dead code