1259698 - Drop nsEventStatus_eConsumeDoDefault completely and if it's necessary for APZC, WidgetEvent::mFlags should have a new flag

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

nsEventStatus_eConsumeDoDefault is now only compared with APZ related methods.
http://mxr.mozilla.org/mozilla-central/search?string=nsEventStatus_eConsumeDoDefault

So, we can drop this odd state from nsEventStatus enum and add a new flag for specific situation.

I still don't understand what means that when nsEventStatus_eConsumeDoDefault is set in APZ.

mstange, if you'd explain the meaning, I'd be happy because it helps to name the new flag. (I feel that, consumed (not just handled) but do its default doesn't make sense)

Comment 1

[Botond Ballo [:botond]]

APZ's interpretation of these values is explained here [1]. Let me know if anything is still unclear, I can elaborate on them.

[1] https://dxr.mozilla.org/mozilla-central/rev/d5f3da0cfe7ccf846c354014c9b059fad6ba0de5/gfx/layers/apz/src/APZCTreeManager.h#164

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

(In reply to Botond Ballo [:botond] from comment #1)
> APZ's interpretation of these values is explained here [1]. Let me know if
> anything is still unclear, I can elaborate on them.
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/rev/
> d5f3da0cfe7ccf846c354014c9b059fad6ba0de5/gfx/layers/apz/src/APZCTreeManager.
> h#164

Thank you for your quick reply. But unfortunately, I don't have much time due to some urgent bugs including fixing regressions. So, I'll be back next month (I really hope so) but if somebody wants to steal this bug, feel free to take this.