1240662 - Pass WebGL2 conformance test framebuffer-texture-layer

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add max level check for framebufferTextureLayer.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8709279 [details] [diff] [review]
Add max level check for framebufferTextureLayer.

Review of attachment 8709279 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +298,5 @@
>  
> +        if (level < 0)
> +            return ErrorInvalidValue("framebufferTextureLayer: level must be >= 0.");
> +
> +        const auto fnFloorPOT = [](uint32_t& val) {

Use FloorLog2() from mfbt/MathAlgorithms.h.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add max level check for framebufferTextureLayer v2.

Address Jeff's comment.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1511e9ff3502

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/235d8796a279

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/235d8796a279