Closed Bug 1234310 Opened 10 years ago Closed 10 years ago

Enable navigation-redirect.https.html for e10s

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
e10s + ---
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jdm, Assigned: jdm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Enable navigation-redirect.https.html for e10s
1.05 KB, patch
ehsan.akhgari
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Now that bug 1233845 landed, the test doesn't need to be disabled any more since it doesn't crash.
Assignee: nobody → josh
Status: NEW → ASSIGNED
Does this test pass the try server given that bug 1233245 hasn't landed yet?
Also I was going to enable it in bug 1219469 anyway. This will just make me rebase once more. ;-)
Blocks: e10s-tests
tracking-e10s: --- → +
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s I was wrong before. This time I read the patch!
Attachment #8700733 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/93c07c3aeab9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s Approval Request Comment [Feature/regressing bug #]: 1137287 [User impact if declined]: Missing test coverage for bug 1233845 [Describe test coverage new/current, TreeHerder]: This is enabling a test for bug 1233845's uplift. [Risks and why]: None. [String/UUID change made/needed]: None.
Attachment #8700733 - Flags: approval-mozilla-beta?
Attachment #8700733 - Flags: approval-mozilla-aurora?
Comment on attachment 8700733 [details] [diff] [review] Enable navigation-redirect.https.html for e10s More tests is good! FYI, you don't need to request for an uplift for test only change.
Attachment #8700733 - Flags: approval-mozilla-beta?
Attachment #8700733 - Flags: approval-mozilla-beta+
Attachment #8700733 - Flags: approval-mozilla-aurora?
Attachment #8700733 - Flags: approval-mozilla-aurora+
This doesn't seem to apply to beta. Can we get a rebased patch if it needs to go to 44?
Flags: needinfo?(josh)
Looks like bug 1200677 needs to be uplifted.
Flags: needinfo?(josh)
Specifically, it introduces the test that is modified here. I believe test-only things don't need approval, so can it just be uplifted along with this patch?
Flags: needinfo?(wkocher)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: