1217198 - Multiline string autocompletion is not triggered for `foo bar`

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Brian Grinstead [:bgrins]]

After Bug 1216668, it works for:

* `foo`.
* `foo
   bar`.

But typing `foo bar`. doesn't open up the autocompletion popup

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: console-autocomplete-multiline-TESTCASE.patch

Failing test case

Comment 2

[Brian Grinstead [:bgrins]]

This bug should be used to investigate switching from the combo of hand rolled parsing and Parser.jsm to using acorn to tokenize the input string.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1217198 - Better autocompletion for template literals; r=Honza.

Add a new template literal state to findCompletionBeginning so we can
better handle the autocompletion for them.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY push https://treeherder.mozilla.org/#/jobs?repo=try&revision=eee2fdca707f7eb8cd803da507a00d6220e7d114&selectedJob=197171453

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9005990 [details]
Bug 1217198 - Better autocompletion for template literals; r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc074d42aa91
Better autocompletion for template literals; r=Honza.

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bc074d42aa91