1189871 - Add event to add/remove permissions for Graphene

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Brian R. Bondy [:bbondy]]

There should be an event in b2g/chrome/content/shell.js which wraps setting and removing permissions.

It would for example call:

Services.perms.add(slashdotURI, 'trackingprotection', Services.perms.ALLOW_ACTION);

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: permission-apis.diff

Comment 2

[Brian R. Bondy [:bbondy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ace3e22c52

Comment 3

[Brian R. Bondy [:bbondy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dace7b1b33e

Comment 4

[Brian R. Bondy [:bbondy]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4595fcf7f37090d7799ad6478651677747dbe5c0
changeset:  4595fcf7f37090d7799ad6478651677747dbe5c0
user:       Brian R. Bondy <[e-mail]>
date:       Mon Aug 10 17:00:01 2015 -0400
description:
Bug 1189871 - Add event to add/remove permissions for Graphene. r=fabrice

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4595fcf7f370

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Any reason why you need to create these events than navigator.mozPermissionSettings other than both you and your reviewer does not know it exists?

https://developer.mozilla.org/en-US/docs/Web/API/PermissionSettings

Comment 7

[Brian R. Bondy [:bbondy]]

If it does the same and was available when this landed on larch, then no.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Could you file a bug to get these event listeners removed, once you remove the dependency? It would be better if we leverage existing and testable code path.

I don't really know where this is being used...

Thanks!

Comment 9

[Brian R. Bondy [:bbondy]]

Done, thanks for the suggestion.