1186696 - PeerConnection.js: TypeError: Argument 2 of EventTarget.setEventHandler is not callable.

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

JavaScript error: resource://gre/components/PeerConnection.js, line 610: TypeError: Argument 2 of EventTarget.setEventHandler is not callable.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Right, so every EventHandler attribute must swallow object (TreatNonObjectAsNull) because some Dell website did something silly in 2013? [1]

If so, then we have more bugs to file:
onprogress [2]
oncontactchange [3]
ondownloadstart [4]
onstatechange [5]
onmessage [6]
...

[1] https://lists.w3.org/Archives/Public/public-script-coord/2013OctDec/0412.html
[2] http://mxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.js?rev=932a80206f57#499
[3] http://mxr.mozilla.org/mozilla-central/source/dom/contacts/ContactManager.js?rev=66f5705f110d#84
[4] http://mxr.mozilla.org/mozilla-central/source/dom/downloads/DownloadsAPI.js?rev=4d0ef24554ca#65
[5] http://mxr.mozilla.org/mozilla-central/source/dom/downloads/DownloadsAPI.js?rev=4d0ef24554ca#311
[6] http://mxr.mozilla.org/mozilla-central/source/dom/engineeringmode/EngineeringModeAPI.js#87

OK I only got to 'e' in the alphabet, but there are more, and these are only the JSImplemented ones, so you get the idea: there are a lot of these, and they all presumably have the same problem.

Bz, what's the answer here?

A) Change all of these to:

   typeof handler == "function" && this.__DOM_IMPL__.setEventHandler("onfoo", handler);

B) Make some new NonDellEventHandler that throws or is TreatNonCallableAsNull? 

C) Something else?

Comment 2

[Boris Zbarsky [:bzbarsky]]

> because some Dell website did something silly in 2013?

Welcome to the web.  Note that I would be surprised if the Dell site were the only one doing that sort of thing....

The right answer here is to change our setEventHandler thing to deal.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Event handlers on JS-implemented webidl interfaces should have the same behavior as other event handlers: accept all values, convert non-objects to null

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8637743 [details] [diff] [review]
Event handlers on JS-implemented webidl interfaces should have the same behavior as other event handlers: accept all values, convert non-objects to null

r+ I guess. allowTreatNonCallableAsNull handling is a bit hard to follow.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yeah, once we move Promise off webidl we should clean it up a bit...

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6327a01d4687

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6327a01d4687