Closed Bug 1184320 Opened 10 years ago Closed 10 years ago

Write UA override for mobile gmail

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(p11+, firefox41 fixed, firefox42 fixed, fennec41+)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
p11 + ---
firefox41 --- fixed
firefox42 --- fixed
fennec 41+ ---

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

(Keywords: site-compat)

Attachments

(2 files, 2 obsolete files)

1184320-AURORA-Add-UA-override-to-remove-Android-vers.patch
1.33 KB, patch
miketaylr
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
1184320.-Add-UA-override-to-remove-Android-versi.patch
856 bytes, patch
miketaylr
: review+
Details | Diff | Splinter Review
Adding the Android version number (Bug 1169772) trips up Google's version detection and sends us something fancier but broken-er. Until we can get Google to update their detection we should send a version-less override to mail.google.com. With ua-override.json coming into play (Bug 1184268), we can write an override for 42+ there. But we'll also need an old-skool pref in mobile.js for 41.
tracking-fennec: --- → ?
Blocks: 1169772
Depends on: 1184268
Keywords: site-compat
Gonna stash these here until Bug 1184268 lands.
Assignee: nobody → miket
The bug in question related to this patch https://webcompat.com/issues/1333
See Also: → https://webcompat.com/issues/1333
tracking-fennec: ? → 42+
tracking-p11: --- → +
tracking-fennec: 42+ → 41+
Comment on attachment 8634434 [details] [diff] [review] 1184320.-Add-UA-override-to-remove-Android-versi.patch Sebastian, would you mind reviewing?
Attachment #8634434 - Flags: review?(s.kaspari)
Attachment #8634435 - Flags: review?(s.kaspari)
Comment on attachment 8634434 [details] [diff] [review] 1184320.-Add-UA-override-to-remove-Android-versi.patch Review of attachment 8634434 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8634434 - Flags: review?(s.kaspari) → review+
Comment on attachment 8634435 [details] [diff] [review] 1184320-AURORA-Add-UA-override-to-remove-Android-vers.patch Review of attachment 8634435 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8634435 - Flags: review?(s.kaspari) → review+
Thanks!
Adding r=Sebastian to commit message, carrying forward r+.
Attachment #8634435 - Attachment is obsolete: true
Attachment #8635472 - Flags: review+
Same thing for this patch.
Attachment #8634434 - Attachment is obsolete: true
Attachment #8635473 - Flags: review+
Sheriffs, checkin-needed just for "1184320.-Add-UA-override-to-remove-Android-versi.patch" -- I still need approval for the AURORA one. No try run because it just adds a UA override to ua-update.json. But it builds locally and works as expected.
Keywords: checkin-needed
Comment on attachment 8635472 [details] [diff] [review] 1184320-AURORA-Add-UA-override-to-remove-Android-vers.patch Approval Request Comment [Feature/regressing bug #]: We tripped up Google's UA detection with Bug 1169772 and get sent an unusable Gmail for Fennec users. [User impact if declined]: Gmail doesn't work and users get sad. [Describe test coverage new/current, TreeHerder]: Manual testing. [Risks and why]: No real risks. This sends a different user-agent string to the mail.google.com domain, and only that domain. [String/UUID change made/needed]: None
Attachment #8635472 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4d3cd827af57
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
40 should not be affected, FWIW.
Comment on attachment 8635472 [details] [diff] [review] 1184320-AURORA-Add-UA-override-to-remove-Android-vers.patch Was verified by dev locally, let's uplift to Aurora.
Attachment #8635472 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Mike Taylor [:miketaylr] from comment #14) > 40 should not be affected, FWIW. Mike, that was my bad. I meant to indicate status-firefox41 to "affected". Thanks!
No worries. ^_^
Let's remove the UA override for GMail. Should we open a new bug, or should we just reuse this one. See https://webcompat.com/issues/1333
Flags: needinfo?(miket)
I'll open a new bug.
Flags: needinfo?(miket)
See Also: → 1269049
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: