1180881 - Assertion failure: mGotTimecodeScale, at WebMBufferedParser.cpp:172

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.webm

Assertion failure: mGotTimecodeScale, at /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/webm/WebMBufferedParser.cpp:172

==4989==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f1e3b574b2a sp 0x7f1e05359900 bp 0x7f1e05359bb0 T57)
    #0 0x7f1e3b574b29 in mozilla::WebMBufferedParser::Append(unsigned char const*, unsigned int, nsTArray<mozilla::WebMTimeDataOffset>&, mozilla::ReentrantMonitor&) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/webm/WebMBufferedParser.cpp:148
    #1 0x7f1e3b5758a8 in mozilla::WebMBufferedState::NotifyDataArrived(unsigned char const*, unsigned int, long) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/webm/WebMBufferedParser.cpp:331
    #2 0x7f1e3b57c6db in mozilla::WebMReader::NotifyDataArrivedInternal(unsigned int, long) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/webm/WebMReader.cpp:838
    #3 0x7f1e3b2295d2 in mozilla::MediaDecoderReader::NotifyDataArrived(mozilla::media::Interval<long> const&) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/obj-firefox/dom/media/../../dist/include/MediaDecoderReader.h:255
    #4 0x7f1e3b228ca5 in mozilla::MediaDecoderReader::DoThrottledNotify() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/MediaDecoderReader.cpp:232
    #5 0x7f1e3b2286d8 in mozilla::MediaDecoderReader::ThrottledNotifyDataArrived(mozilla::media::Interval<long> const&) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/MediaDecoderReader.cpp:204
    #6 0x7f1e3b319df4 in void nsRunnableMethodArguments<mozilla::media::Interval<long> >::apply<mozilla::MediaDecoderReader, void (mozilla::MediaDecoderReader::*)(mozilla::media::Interval<long> const&)>(mozilla::MediaDecoderReader*, void (mozilla::MediaDecoderReader::*)(mozilla::media::Interval<long> const&)) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/obj-firefox/dom/media/../../dist/include/nsThreadUtils.h:631
    #7 0x7f1e3b319c41 in nsRunnableMethodImpl<void (mozilla::MediaDecoderReader::*)(mozilla::media::Interval<long> const&), true, mozilla::media::Interval<long> >::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/obj-firefox/dom/media/../../dist/include/nsThreadUtils.h:825
    #8 0x7f1e3b1f3917 in mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/TaskDispatcher.h:181
    #9 0x7f1e3b337ee7 in mozilla::MediaTaskQueue::Runner::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/dom/media/MediaTaskQueue.cpp:256
    #10 0x7f1e37bfe3a1 in nsThreadPool::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/xpcom/threads/nsThreadPool.cpp:221
    #11 0x7f1e37bfe64c in non-virtual thunk to nsThreadPool::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads0.cpp:235
    #12 0x7f1e37bf90ee in nsThread::ProcessNextEvent(bool, bool*) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/xpcom/threads/nsThread.cpp:848
    #13 0x7f1e37c6e76e in NS_ProcessNextEvent(nsIThread*, bool) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/xpcom/glue/nsThreadUtils.cpp:265
    #14 0x7f1e383baba3 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/ipc/glue/MessagePump.cpp:326
    #15 0x7f1e38330431 in MessageLoop::RunInternal() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/ipc/chromium/src/base/message_loop.cc:234
    #16 0x7f1e383302d8 in MessageLoop::Run() /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/ipc/chromium/src/base/message_loop.cc:201
    #17 0x7f1e37bf5d2e in nsThread::ThreadFunc(void*) /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/xpcom/threads/nsThread.cpp:360
    #18 0x7f1e45ecf771 in _pt_root /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/nsprpub/pr/src/pthreads/ptthread.c:212
    #19 0x7f1e49402181 in start_thread /build/buildd/eglibc-2.19/nptl/pthread_create.c:312
    #20 0x7f1e4850347c in clone /build/buildd/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Comment 1

[Jean-Yves Avenard [:jya]]

This is a regression from bug 1175768

Comment 2

[Jean-Yves Avenard [:jya]]

Oh actually this is a similar backtrace, though not the same as the one I just experienced. So will open a different bug

Comment 3

[Tyson Smith [:tsmith]]

Attachment: test_case.webm

Smaller test case.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

mozregression says this testcase stopped asserting when bug 1314533 landed. Any reason to leave this open, jya? Also, should we land the test from this bug or were the tests from bug 1314533 sufficient to cover this too?

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Ryan, I did a quick test (by re-adding the assertions and running all media tests), and I didn't hit the assertions, so we currently don't have a test that covers them.

So maybe you could add the test case from this bug as part of your "crashtest all the things" mission? Thanks. (Or please let me know if I can help.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f447346324a
Add crashtest. r=me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f447346324a