1170799 - Remove unused SetBlockingOnload declaration from nsImageLoadingContent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Josh Matthews [:jdm]]

It doesn't appear to be implemented anywhere. No test required; if mozilla-central still compiles after removing it, that's good enough.

Code: dom/base/nsImageLoadingContent.h

Comment 1

[Tyler Steiman]

Hey I would love to work on this bug, can somebody please assign it to me? Thanks!

Comment 2

[Tyler Steiman]

Attachment: Patch to Remove setBlockingOnload

After removing setBlockingOnload Firefox builds and runs cleanly.

Comment 3

[Josh Matthews [:jdm]]

Looks great! I'm not a reviewer for this part of the code though; you'll need to choose someone from the list at https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the suggested reviewers dropdown).

Comment 4

[Tyler Steiman]

Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1170799 - removes unused declaration setBlockingOnLoad

Comment 5

[Tyler Steiman]

(In reply to Josh Matthews [:jdm] from comment #3)
> Looks great! I'm not a reviewer for this part of the code though; you'll
> need to choose someone from the list at
> https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the
> suggested reviewers dropdown).

I do apologize, I saw your name in the suggested reviewers dropdown. Just for my future knowledge, are bolded names in the dropdown not reviewers and just mentors? I'm new and trying to get the hang of things so thank you for any help!

Comment 6

[Josh Matthews [:jdm]]

(In reply to Muhsin Ali from comment #5)
> (In reply to Josh Matthews [:jdm] from comment #3)
> > Looks great! I'm not a reviewer for this part of the code though; you'll
> > need to choose someone from the list at
> > https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the
> > suggested reviewers dropdown).
> 
> I do apologize, I saw your name in the suggested reviewers dropdown. Just
> for my future knowledge, are bolded names in the dropdown not reviewers and
> just mentors? I'm new and trying to get the hang of things so thank you for
> any help!

That's not a problem; the mentor should always be in a good position to suggest another review if they're not appropriate. I assume bolded names are mentors, and there may or may not be overlap between the reviewers. Finally, you may want to select Ehsan or Andrea as the reviewer; I'm not sure if Mounir is active any longer. Sorry this process isn't clearer!

Comment 7

[Tyler Steiman]

Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1170799 - removes unused declaration setBlockingOnload

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, my backlog is long enough that you should probably find another reviewer for this.

Comment 9

[Tyler Steiman]

I don't have commit access, can someone help me with checking this in? Thanks!!

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Add checkin-needed keyword.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49dff160b431

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/49dff160b431