1134540 - All tests using nsIDOMWindowUtils.sendKeyEvent() should use nsITextInputProcessor

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

nsIDOMWindowUtils.sendKeyEvent() is now deprecated. All tests using it should use nsITextInputProcessor, instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Hmm, looks like that we need to fix for bug 968056 because TextInputProcessor decides if keypress event should be fired for each keyboard event but tests using nsIDOMWindowUtils.sendKeyEvent() don't do it.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bf8cc91f3af155d683f9c9b9a5c9b598201e014

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdd782eb0a59c5e3b309792af85d56b34c265fd0

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5533436f6773bf2454a2d04f2f155e92c566ce8b

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1e9c295ef819f17978df724f2dea4f1df68a07b

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent()

nsIDOMWindowUtils.sendKeyEvent() can dispatch any keyboard events, i.e.,
may dispatch different key events from actual Gecko's behavior.  Instead,
they should use nsITextInputProcessor directly or synthesizeKey() of
EventUtils which wraps nsITextInputProcessor.

Review commit: https://reviewboard.mozilla.org/r/216826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216826/

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8947008 [details]
Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent()

https://reviewboard.mozilla.org/r/216826/#review222656

rs+

Should we remove nsIDOMWindowUtils.sendKeyEvent()?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Comment on attachment 8947008 [details]
Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent()

https://reviewboard.mozilla.org/r/216826/#review222656

Yes, I have a patch. However, I'll wait fixes of comm-central for a couple of weeks. So, I'd like to remove it in the cycle of 60.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5450e8bff04
Make all tests stop using nsIDOMWindowUtils.sendKeyEvent() r=smaug

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e5450e8bff04