1107956 - intl/icu/source/i18n/msgfmt.cpp:789:18: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]

Status: RESOLVED DUPLICATE of bug 1075758

(Core :: Internationalization, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
intl/icu/source/i18n/msgfmt.cpp:789:18: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]
            if (&newFormat == NULL) {
                 ^~~~~~~~~    ~~~~
}

From a comment at the top of this file, it looks like it was originally auto-converted from Java, which makes this bogus comparison a bit more sensible. (It might do something useful in java, but it does not in C++.) A bit similar to bug 1073707.

Anyway, we probably want to just drop the comparison, since it can't fail.

Comment 1

[Makoto Kato [:m_kato]]

This issue is http://bugs.icu-project.org/trac/ticket/10976.  This was fixed by updating to 55.1