1068075 - Fix failure caused by [TypeError: redeclaration of variable ...]

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Bug 1001090 enabled some strict checking for let declarations. This causes some Lightning tests to fail. There might be more failures in Lightning itself. From https://tbpl.mozilla.org/php/getParsedLog.php?id=48189216&tree=Thunderbird-Trunk:

> INFO -  Diagnostic: TypeError: redeclaration of variable comp at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_alarm.js:519

> INFO -  Diagnostic: TypeError: redeclaration of variable parser at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_ics_parser.js:54

> INFO -  Diagnostic: TypeError: redeclaration of variable occ at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_recur.js:417

> INFO -  Diagnostic: TypeError: redeclaration of variable a at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_utils.js:63

> INFO -  Diagnostic: TypeError: redeclaration of variable prop at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_calmgr.js:219

> INFO -  Diagnostic: TypeError: redeclaration of variable refDate at resource://calendar/modules/calExtract.jsm:1141

> WARNING -  TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_extract.js | TypeError: extractor is undefined at C:/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_extract.js:26

Comment 1

[Stefan Sitter [:ssitter]]

From https://tbpl.mozilla.org/php/getParsedLog.php?id=48188878&tree=Thunderbird-Trunk:

> JavaScript error: chrome://calendar/content/calendar-multiday-view.xml, line 1606: TypeError: redeclaration of variable lateralColumns

> JavaScript error: chrome://calendar/content/calendar-multiday-view.xml, line 3312: TypeError: redeclaration of let d

> JavaScript error: chrome://calendar/content/calendar-task-tree.xml, line 150: TypeError: redeclaration of variable tree

> JavaScript error: chrome://calendar/content/calendar-views.js, line 309: TypeError: redeclaration of variable view

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: fix errors reported in comment 0

This should fix the errors reported in comment 0. I did not get xpcshell-tests running in local build therefore you might want to test before commit.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: fix errors

fix some error locations

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8490270 [details] [diff] [review]
fix errors

Review of attachment 8490270 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch and finding all the error locations! I have my fingers crossed that this covers everything!

Comment 5

[Stefan Sitter [:ssitter]]

There might be more error locations. The patch fixes only the ones reported during unit test execution and a few reported when running Lightning and creating an event.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e2d2b3848901>

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: additional fixups, v1

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8490394 [details] [diff] [review]
additional fixups, v1

https://hg.mozilla.org/comm-central/rev/76a498138f36