1067697 - Enable VDA decoder in 10.6

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

In Bug 1062654, VDA decoder was disabled in 10.6 as it often crashes (and in particular the gizmo.mp4 video found in the mochitest)

VDA should be working in 10.6 too.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Work around 10.6 VDA bug

Re-enable VDA on 10.6. Work around retain/release error in 10.6

Comment 2

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=6b78bd0ef5f9

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Work around 10.6 VDA bug

Re-enable VDA on 10.6. Work around retain/release error in 10.6

Comment 4

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=03a55701a640

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Account for fmp4 now potentially working on MacOS X 10.6

Update mochitest for 10.6

Comment 6

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=bed3070c9d12

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8489815 [details] [diff] [review]
Work around 10.6 VDA bug

Review of attachment 8489815 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: content/media/fmp4/apple/AppleVDADecoder.h
@@ +49,5 @@
>    virtual nsresult Shutdown() MOZ_OVERRIDE;
>  
>    nsresult OutputFrame(CVPixelBufferRef aImage,
>                         nsAutoPtr<AppleFrameRef> aFrameRef);
> +  bool mIs106;

This can be private, no?

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Work around 10.6 VDA bug

Carrying r+. Remove use of Gestalt. Make variable private

Comment 9

[Jean-Yves Avenard [:jya]]

https://tbpl.mozilla.org/?tree=Try&rev=ae729351d0c3

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a73501f2bd94
https://hg.mozilla.org/integration/mozilla-inbound/rev/612de448f2cf

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a73501f2bd94
https://hg.mozilla.org/mozilla-central/rev/612de448f2cf