(In reply to Cristina Horotan [:chorotan] from comment #27) > Backed out for causing reftest failures on details-percentage-height-children.html Ah, sorry about that -- huh, so that's the test I fixed in bug 1981803. Aha, I hadn't noticed that Keith folded a *different* workaround for that same test-failure into the patch on this bug here: https://phabricator.services.mozilla.com/D257081?vs=1100047&id=1103614#toc Keith's workaround and my fix in bug 1981803 don't play nicely together, which is why it fails. I guess I didn't catch that in comment 24 because that Try run had the dependencies' patches but not this bug's patches; whoops. We can remove Keith's workaround from the patch here now, and then I'll do a Try run with that updated patch, and then we can land assuming that Try run looks good.
Bug 1941406 Comment 28 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Cristina Horotan [:chorotan] from comment #27) > Backed out for causing reftest failures on details-percentage-height-children.html Ah, sorry about that -- huh, so that's the test I fixed in bug 1981803. Aha, I hadn't noticed that Keith folded a *different* workaround for that same test-failure into the patch on this bug here: https://phabricator.services.mozilla.com/D257081?vs=1100047&id=1103614#toc Keith's workaround and my fix in bug 1981803 don't play nicely together, which is why it fails. I guess I didn't catch that in comment 24 because that Try run had the dependencies' patches but not this bug's patches; whoops. We can remove Keith's workaround from the patch here now, and then I'll do a Try run with that updated patches, and then we can land assuming that Try run looks good.