Bug 1917885 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
This change added four new methods to the Uint8Array constructor: setFromBase64, setFromHex, toBase64, toHex. We probably weren't running this test with --enable-uint8array-base64 previously.

We need to modify the [failing test](https://searchfox.org/mozilla-central/source/js/src/tests/non262/TypedArray/prototype-constructor-identity.js#44) as follows:
```
-  assertEq(props.length, 2);
+  if (ctor == Uint8Array) {
+    assertEq(props.length, 6);
+  } else {
+    assertEq(props.length, 2);
+  }
```
Please amend your current commit to include this change to the test and resubmit for review.
Revision 1 by
on 
This change added four new methods to the Uint8Array constructor: setFromBase64, setFromHex, toBase64, toHex. We probably weren't running this test with --enable-uint8array-base64 previously.

We need to modify the [failing test](https://searchfox.org/mozilla-central/source/js/src/tests/non262/TypedArray/prototype-constructor-identity.js#44) as follows:
```
-  assertEq(props.length, 2);
+  if (ctor === Uint8Array) {
+    assertEq(props.length, 6);
+  } else {
+    assertEq(props.length, 2);
+  }
```
Please amend your current commit to include this change to the test and resubmit for review.

Back to Bug 1917885 Comment 7